RussellSpitzer commented on code in PR #16077:
URL: https://github.com/apache/iceberg/pull/16077#discussion_r3170215745
##########
core/src/main/java/org/apache/iceberg/FileCleanupStrategy.java:
##########
@@ -84,7 +84,8 @@ public abstract void cleanFiles(
"manifest_length",
"partition_spec_id",
"added_snapshot_id",
- "deleted_data_files_count");
+ "added_files_count",
Review Comment:
I would take this oppertunity to just change this whole thing to
```java
private static final Schema MANIFEST_PROJECTION =
ManifestFile.schema()
.select(
ManifestFile.PATH.name(),
ManifestFile.LENGTH.name(),
ManifestFile.SPEC_ID.name(),
ManifestFile.SNAPSHOT_ID.name(),
ManifestFile.ADDED_FILES_COUNT.name(),
ManifestFile.DELETED_FILES_COUNT.name());
```
Or as a followup add Schema.select(Types.NestedField)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
