sachinnn99 commented on PR #16167: URL: https://github.com/apache/iceberg/pull/16167#issuecomment-4351253106
Thanks for the review! I looked at `slice()` — its `EOFException` is intentional since it's a "read exactly N bytes" operation (not part of the `InputStream` contract). Callers expect either the full slice or a failure, so throwing there is the correct behavior. The fix here is scoped to the no-arg `read()`, which has a clear contract violation per `InputStream.read()` javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
