amogh-jahagirdar commented on PR #16092: URL: https://github.com/apache/iceberg/pull/16092#issuecomment-4347661464
>I was trying to cross-check with https://docs.google.com/document/d/1k4x8utgh41Sn1tr98eynDKCWq035SV_f75rtNHcerVw/edit?tab=t.0 that the right fields are required/optional in the builder but I think the doc hasn't been updated with the latest changes that we have in the code here? My bad on this, the implementaiton does align with the table in the last tab in the doc, but the last tab table needs to be merged into the main one. I'll do that. One gap where the implementation is correct but the spec isn't is the file count in manifests, in the spec entry proposal it's a long but I think it should be an integer (a manifest with 2+ billion entries doesn't seem like a real thing ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
