boaz-gold commented on issue #15898:
URL: https://github.com/apache/iceberg/issues/15898#issuecomment-4333563721
@anoopj — you're right, and I apologize for the error. The reference chain I
described was backwards.
The direction is S3FileIO → PrefixedS3Client → S3AsyncClient →
ScheduledExecutorService → Thread, not the other way around. The AWS SDK has no
knowledge of Iceberg's S3FileIO. I should have been more careful before
posting.
@xiaoxuandev — thank you for independently reproducing this and for PR
#16129. The shared ScheduledExecutorService approach is clean and the
NonClosingScheduledExecutorService wrapper is a good detail.
Looking at the code, S3InputFile and S3OutputFile both use the sync S3Client
by default (via client()), so the patch covering the sync client builder path
appears to address the primary leak path for standard S3FileIO usage. I will be
watching the PR closely and happy to test it against our setup once it's ready
(not needing to wait for AWS to release)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
