laskoviymishka opened a new issue, #940: URL: https://github.com/apache/iceberg-go/issues/940
Parent: #829 `AssertRefSnapshotID.Validate` (`table/requirements.go`) returns errors of the form `requirement failed: assert ref snapshot id` without including the actual versus expected snapshot ids. Java's equivalent `AssertRefSnapshotID` formats the mismatch into the message so the operator can see what changed — iceberg-go does not, which makes commit-conflict triage harder than it should be. The struct already carries the expected `ref` name and snapshot id, and `Validate` receives the current `Metadata` from which the actual head can be read. Format both into the error: `"requirement failed: ref %q expected snapshot %d, found %d"`. Update the corresponding test in `table/requirements_test.go`. Mechanical wrap; matches the pattern used by other typed errors in the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
