amogh-jahagirdar commented on code in PR #16102: URL: https://github.com/apache/iceberg/pull/16102#discussion_r3144040396
########## flink/v2.1/flink-runtime/LICENSE: ########## @@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2 -------------------------------------------------------------------------------- -This product bundles Apache Hive. Review Comment: I'm not sure about this, when I look at the JAR I see actual classes being bundled (via ORC) as you mentioned. So I think at least the compiled classes are still being bundled, more than just the META-INF? Does that change if we'd include it here or not (just looks like the storage API as far as I can tell)? ``` org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal$1.class org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal.class org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimalV1.class ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
