vladislav-sidorovich commented on code in PR #15407: URL: https://github.com/apache/iceberg/pull/15407#discussion_r3143763703
########## delta-lake/src/test/resources/delta/golden/README.md: ########## @@ -0,0 +1,69 @@ +<!-- + - Licensed to the Apache Software Foundation (ASF) under one + - or more contributor license agreements. See the NOTICE file + - distributed with this work for additional information + - regarding copyright ownership. The ASF licenses this file + - to you under the Apache License, Version 2.0 (the + - "License"); you may not use this file except in compliance + - with the License. You may obtain a copy of the License at + - + - http://www.apache.org/licenses/LICENSE-2.0 + - + - Unless required by applicable law or agreed to in writing, + - software distributed under the License is distributed on an + - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + - KIND, either express or implied. See the License for the + - specific language governing permissions and limitations + - under the License. + --> + +# Delta Lake Golden Tables + +## Overview +This directory contains the **Delta Lake Golden Tables**, a set of reference data tables used to verify compliance with the Delta Lake protocol. + +These tables cover various features of the Delta Lake specification (e.g., different protocol versions, partition strategies, checkpoints, and data types). They act as a "compliance suite" to ensure that this project's reader/writer implementation can correctly handle data produced by the official Delta Lake reference implementation. + +## Origin & Attribution +These resources were sourced directly from the open-source Delta Lake project. + +* **Source Repository:** [delta-io/delta](https://github.com/delta-io/delta) +* **Module Path:** `connectors/golden-tables/src` +* **License:** Apache License 2.0 (See [LICENSE](https://github.com/delta-io/delta/blob/master/LICENSE.txt) in the project) + +## Purpose +The primary goal of these tables is **integration testing**. + +Each folder represents a specific "edge case" or feature configuration in Delta Lake. By running the conversion against +these tables, we verify that: +1. **Protocol Versioning:** We respect `minReaderVersion` and `minWriterVersion`. +2. **Feature Support:** We can read tables with `checkpoints`, `vacuumed` files, `deletion vectors`, or `column mapping`. +3. **Data Consistency:** We read the correct number of rows and column values as defined by the transaction log (`_delta_log`). + +## Table Inventory & Explanations + +The tables are typically named after the specific feature they test. Below are explanations of common patterns found in this suite: Review Comment: Not really. Initially I added all the table, but then I removed them from the PR to reduce the PR size. I will add other tables in the follow-up PRs to keep test coverage robust. The plan described in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
