laserninja commented on issue #16032: URL: https://github.com/apache/iceberg/issues/16032#issuecomment-4320389428
Sure! I've added `TestParquetFilters` with tests that cover this. The key test is `alwaysFalseReturnsNoop()`. Before the fix, `ParquetFilters.convert()` would pass the internal `AlwaysFalse.INSTANCE` sentinel through to `FilterCompat.get(pred)`, which Parquet doesn't understand. After the fix it correctly returns `FilterCompat.NOOP`. Additional tests verify the existing `AlwaysTrue` → NOOP behavior, that real predicates still produce active filters, and that composite expressions like `not(alwaysFalse)` and `and(alwaysFalse, pred)` also resolve to NOOP via the visitor's existing handling. The one-line fix adds `&& pred != AlwaysFalse.INSTANCE` to the null/sentinel check in `convert()`. Will open a PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
