joyhaldar commented on PR #16097: URL: https://github.com/apache/iceberg/pull/16097#issuecomment-4318364369
> I think this looks good. +1 on an e2e test to validate the wiring works as intended. Thank you for your review @mxm. I have added `TestFlinkUuidType` covering: - `UUID` round-trip read across `Avro`, `Parquet`, `ORC` (Generic writer -> Flink read) - `UUID` write through Flink writer across all three formats (Flink write -> Generic read) - SQL INSERT failing with `fixed[16] cannot be promoted to uuid` across all three formats The SQL failure documents what @Guosmilesmile ran into in his comment, it's at Iceberg's schema check before reaching the writers this PR fixes IIUC. cc: @pvary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
