kevinjqliu commented on code in PR #625:
URL: https://github.com/apache/iceberg-cpp/pull/625#discussion_r3138673505
##########
.github/workflows/docs.yml:
##########
@@ -63,9 +63,12 @@ jobs:
- name: Deploy to gh-pages
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
```suggestion
GITHUB_TOKEN: ${{ github.token }}
```
##########
.github/workflows/docs.yml:
##########
@@ -63,9 +63,12 @@ jobs:
- name: Deploy to gh-pages
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
git config --global user.name 'GitHub Actions'
git config --global user.email '[email protected]'
+ git remote set-url origin
"https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git"
Review Comment:
```suggestion
git remote set-url origin
"https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]