123digits opened a new pull request, #2366:
URL: https://github.com/apache/iceberg-rust/pull/2366
Writer emits the spec-compliant {"spec-id":N,"fields":[...]} object; reader
accepts both that and the historical bare-fields array.
Without these two changes, iceberg-rust cannot share a table with any
non-rust Iceberg writer in either direction:
* iceberg-rust fast_append fails with "Fail to parse partition spec in
manifest metadata, source: invalid type: map, expected a sequence" when the
parent snapshot's manifest was written by iceberg-java / iceberg-cpp /
pyiceberg, because those write the partition-spec user-metadata as the
spec-compliant object and the rust reader rejects that shape.
* Non-rust Iceberg engines reject iceberg-rust-written manifests because
iceberg-rust emits a bare fields array, which is not what the Iceberg spec nor
other implementations expect.
Existing manifest tests (including round-trip tests in
writer::tests::test_add_delete_existing and
test_v3_delete_manifest_delete_file_roundtrip) pass unchanged.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
