nastra commented on code in PR #16098:
URL: https://github.com/apache/iceberg/pull/16098#discussion_r3135888168
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/sql/TestDeleteFrom.java:
##########
@@ -38,14 +48,70 @@
@ExtendWith(ParameterizedTestExtension.class)
public class TestDeleteFrom extends CatalogTestBase {
+ @Parameter(index = 3)
+ private int formatVersion;
+
+ @Parameters(name = "catalogName = {0}, implementation = {1}, config = {2},
formatVersion = {3}")
+ protected static Object[][] parameters() {
+ List<Object[]> catalogParameters = Lists.newArrayList();
+ catalogParameters.add(
Review Comment:
this is what's already defined in the super class, so we're just adding
format version parameters here a few lines below this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
