stevenzwu commented on code in PR #15854:
URL: https://github.com/apache/iceberg/pull/15854#discussion_r3133592605
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -87,9 +87,11 @@ void inheritFrom(Tracking manifestTracking) {
this.snapshotId = manifestTracking.snapshotId();
}
+ // both sequence numbers inherit from file sequence number because
manifests
+ // do not distinguish between data and file sequence numbers
if (status == EntryStatus.ADDED) {
if (dataSequenceNumber == null) {
- this.dataSequenceNumber = manifestTracking.dataSequenceNumber();
+ this.dataSequenceNumber = manifestTracking.fileSequenceNumber();
Review Comment:
we should add an assertion that the two seq numbers from `manifestTracking`
are equal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
