lrsb commented on code in PR #16011:
URL: https://github.com/apache/iceberg/pull/16011#discussion_r3130396938
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java:
##########
@@ -1434,6 +1447,59 @@ public void beforeCommitOperation() {
}
}
+ /**
+ * Seeds an ancestor snapshot under a synthetic previous jobId and injects a
replay committable
+ * tagged with that jobId into the main batch. The seed uses {@code
table.newAppend()} directly
+ * rather than a side committer so the real committable's manifest stays
intact.
+ */
+ static class ReplayPreviousJobIdCommittableHook implements CommitHook {
Review Comment:
Tried that, with the side committer committing the replay under a synthetic
previous jobId. It doesn't fit because
FlinkManifestUtil.deleteCommittedManifests deletes the actual file referenced
in manifest.path() after a successful commit and the replay reuses the original
committable's manifest bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
