anoopj commented on code in PR #15854:
URL: https://github.com/apache/iceberg/pull/15854#discussion_r3126788914
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -118,6 +106,62 @@ void testReaderSideFields() {
assertThat(file.tracking().manifestPos()).isEqualTo(7L);
}
+ @Test
+ void testInheritFrom() {
+ TrackingStruct tracking = new TrackingStruct();
+ tracking.set(0, EntryStatus.ADDED.id());
+
+ TrackingStruct manifestTracking = new TrackingStruct();
+ manifestTracking.set(1, 99L);
+ manifestTracking.set(2, 10L);
+ manifestTracking.set(3, 20L);
+
+ tracking.inheritFrom(manifestTracking);
+
+ assertThat(tracking.snapshotId()).isEqualTo(99L);
+ assertThat(tracking.dataSequenceNumber()).isEqualTo(10L);
+ assertThat(tracking.fileSequenceNumber()).isEqualTo(20L);
+ }
+
+ @Test
+ void testInheritFromDoesNotOverrideExisting() {
+ TrackingStruct tracking = new TrackingStruct();
+ tracking.set(0, EntryStatus.ADDED.id());
+ tracking.set(1, 1L);
+ tracking.set(2, 2L);
+ tracking.set(3, 3L);
+
+ TrackingStruct manifestTracking = new TrackingStruct();
+ manifestTracking.set(1, 99L);
+ manifestTracking.set(2, 10L);
+ manifestTracking.set(3, 20L);
+
+ tracking.inheritFrom(manifestTracking);
+
+ assertThat(tracking.snapshotId()).isEqualTo(1L);
+ assertThat(tracking.dataSequenceNumber()).isEqualTo(2L);
+ assertThat(tracking.fileSequenceNumber()).isEqualTo(3L);
+ }
+
+ @Test
+ void testInheritFromOnlyForAdded() {
+ TrackingStruct tracking = new TrackingStruct();
+ tracking.set(0, EntryStatus.EXISTING.id());
+
+ TrackingStruct manifestTracking = new TrackingStruct();
+ manifestTracking.set(1, 99L);
+ manifestTracking.set(2, 10L);
+ manifestTracking.set(3, 20L);
+
+ tracking.inheritFrom(manifestTracking);
+
+ // snapshotId is inherited regardless of status
+ assertThat(tracking.snapshotId()).isEqualTo(99L);
+ // sequence numbers are only inherited for ADDED entries
+ assertThat(tracking.dataSequenceNumber()).isNull();
Review Comment:
Good point. BTW I had moved the inheritance logic from `TrackedFileStruct`
to `TrackingStruct` based on Ryan's feedback. So this was already covered in
`testDoNotInheritSequenceNumberForExistingEntries()`. So I deleted this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
