tanmayrauth commented on PR #917: URL: https://github.com/apache/iceberg-go/pull/917#issuecomment-4292476288
@zeroshade Addressed all review feedback:
- Removed BulkRemovableIO interface and all bulk delete wiring — deferred
to #916
- walkDirectory prefers ListableIO when available, falls back to the
original reflect-based implementation for IO types that don't implement it yet
— no behavioral change for existing users
- blobFileIO.WalkDir uses url.JoinPath and preserves Azure URI userinfo
- Removed unnecessary empty cleanRoot guard from LocalFS.WalkDir
This PR is now self-contained: ListableIO interface + implementations on
LocalFS and blobFileIO + fallback to original code. No dependency on #916.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
