amogh-jahagirdar commented on code in PR #16031:
URL: https://github.com/apache/iceberg/pull/16031#discussion_r3118266166
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/CommitMetadata.java:
##########
@@ -56,7 +56,7 @@ public static <R, E extends Exception> R withCommitProperties(
ExceptionUtil.castAndThrow(e, exClass);
return null;
} finally {
- COMMIT_PROPERTIES.set(ImmutableMap.of());
+ COMMIT_PROPERTIES.remove();
Review Comment:
I agree with @anoopj analysis, we should be cleaning up via ThreadLocals
remove but I don't think it's a significant "leak" either for a single
threadLocal map (per thread, which I believe is only 1 thread on the driver).
The description references "executor threads" but I'm not sure where executor
threads apply here since this looks like it's on the driver commit path, but
let me know if I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
