nastra commented on code in PR #16061:
URL: https://github.com/apache/iceberg/pull/16061#discussion_r3117592366
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -859,6 +859,22 @@ public void testDropNamespace() {
.hasMessage("Namespace db is not empty. Contains 1 table(s).");
}
+ @Test
+ public void testDropNamespaceWithChildNamespace() {
Review Comment:
this test should go into CatalogTests next to testDropNonEmptyNamespace.
You'll have to add an assumption so that it is only executes for catalogs where
supportsNestedNamespaces() returns true. Also instead of childNamespaces let's
rename the method to say nestedNamespaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
