Baunsgaard commented on code in PR #2292:
URL: https://github.com/apache/iceberg-rust/pull/2292#discussion_r3107266128
##########
crates/iceberg/src/delete_vector.rs:
##########
@@ -45,6 +45,26 @@ impl DeleteVector {
self.inner.insert(pos)
}
+ /// Inserts all positions in the range [start, end) into the delete vector.
+ /// If start == end, this method does nothing and returns 0.
+ ///
+ /// # Panics
+ ///
+ /// Panics if start > end (a reversed range indicates a bug in the caller).
+ ///
+ /// Returns the number of newly inserted positions.
+ #[allow(unused)]
Review Comment:
Good question, I wanted to add the range insert to help in exactly this case!
I already made the followup PR in Java :
https://github.com/apache/iceberg/pull/16052
TL;DR; We can get speedups when processing a sorted list of rows with ranges
of deleted rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
