yadavay-amzn opened a new pull request, #16030: URL: https://github.com/apache/iceberg/pull/16030
This fixes a bug where `DefaultAwsClientFactory` applies `S3FileIOProperties.applyServiceConfigurations()` to the synchronous `S3Client` but not to the `S3AsyncClient`. This means settings like `s3.path-style-access`, `s3.dualstack-enabled`, `s3.accelerate-enabled`, and `s3.use-arn-region-enabled` silently do not take effect for async S3 operations. ## Changes 1. **Widened type bound** of `S3FileIOProperties.applyServiceConfigurations()` from `S3ClientBuilder` to `S3BaseClientBuilder<T, ?>` so it accepts both sync and async builders. 2. **Added `applyServiceConfigurations` call** to the `S3AsyncClient.builder()` path in `DefaultAwsClientFactory.s3Async()`. 3. **Added test** `testApplyS3AsyncServiceConfigurations` verifying that path-style access, ARN region, and acceleration settings are correctly applied to the async client builder. Closes #14575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
