bharos commented on issue #16022:
URL: https://github.com/apache/iceberg/issues/16022#issuecomment-4271531158
Validated that the issue is present through a unit test in `TestOAuth2Util` :
```
@Test
void refreshExpiredTokenShouldIncludeOptionalOAuthParams() throws
IOException {
String audience = "https://my-catalog.example.com";;
AuthConfig authConfig =
ImmutableAuthConfig.builder()
.keepRefreshed(true)
.exchangeEnabled(false)
.token("expired_token")
.credential("testClientId:testClientSecret")
.oauth2ServerUri("/v1/token")
.expiresAtMillis(System.currentTimeMillis() - 10_000)
.optionalOAuthParams(ImmutableMap.of("audience", audience,
"scope", "catalog"))
.build();
OAuthTokenResponse response =
OAuthTokenResponse.builder().withToken("refreshed_token").withTokenType(BEARER).build();
try (RESTClient client = Mockito.mock(RESTClient.class);
OAuth2Util.AuthSession session = new
OAuth2Util.AuthSession(Map.of(), authConfig)) {
Mockito.when(client.postForm(any(), anyMap(), any(), anyMap(),
any())).thenReturn(response);
session.refresh(client);
// FAILS: actual form data has no "audience" key
Mockito.verify(client)
.postForm(
any(),
argThat(
formData ->
CLIENT_CREDENTIALS.equals(formData.get(GRANT_TYPE))
&& audience.equals(formData.get("audience"))),
Mockito.eq(OAuthTokenResponse.class),
anyMap(),
any());
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
