kevinjqliu commented on code in PR #15944:
URL: https://github.com/apache/iceberg/pull/15944#discussion_r3102042454
##########
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##########
@@ -36,43 +36,84 @@ env:
DOCKER_REPOSITORY: apache
jobs:
- build:
+ build-images:
if: github.repository_owner == 'apache'
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - runner: ubuntu-latest
+ platform: linux/amd64
+ arch: amd64
+ - runner: ubuntu-24.04-arm
+ platform: linux/arm64
+ arch: arm64
+ runs-on: ${{ matrix.runner }}
+ environment: docker-publish
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+ with:
+ persist-credentials: false
+
+ - uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5
+ with:
+ distribution: zulu
+ java-version: 21
+ - uses:
gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5 #
zizmor: ignore[cache-poisoning] -- cache writes are restricted to the default
branch by setup-gradle
Review Comment:
```suggestion
- uses:
gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5
```
can remove this, i already removed for the rest of the repo
##########
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##########
@@ -36,43 +36,84 @@ env:
DOCKER_REPOSITORY: apache
jobs:
- build:
+ build-images:
if: github.repository_owner == 'apache'
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - runner: ubuntu-latest
+ platform: linux/amd64
+ arch: amd64
+ - runner: ubuntu-24.04-arm
+ platform: linux/arm64
+ arch: arm64
+ runs-on: ${{ matrix.runner }}
+ environment: docker-publish
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+ with:
+ persist-credentials: false
+
+ - uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5
+ with:
+ distribution: zulu
+ java-version: 21
+ - uses:
gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5 #
zizmor: ignore[cache-poisoning] -- cache writes are restricted to the default
branch by setup-gradle
+ - name: Build Iceberg Open API project
+ run: ./gradlew :iceberg-open-api:shadowJar
+ - name: Login to Docker Hub
+ env:
+ DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
+ DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ docker login -u "$DOCKERHUB_USER" -p "$DOCKERHUB_TOKEN"
+ - name: Set the tagged version
+ if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
Review Comment:
```suggestion
# for tag 'apache-iceberg-1.7.1', publish image
'apache/iceberg-rest-fixture:1.7.1'
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
```
i like this comment
##########
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##########
@@ -36,43 +36,84 @@ env:
DOCKER_REPOSITORY: apache
jobs:
- build:
+ build-images:
if: github.repository_owner == 'apache'
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - runner: ubuntu-latest
+ platform: linux/amd64
+ arch: amd64
+ - runner: ubuntu-24.04-arm
+ platform: linux/arm64
+ arch: arm64
+ runs-on: ${{ matrix.runner }}
+ environment: docker-publish
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+ with:
+ persist-credentials: false
+
+ - uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5
+ with:
+ distribution: zulu
+ java-version: 21
+ - uses:
gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5 #
zizmor: ignore[cache-poisoning] -- cache writes are restricted to the default
branch by setup-gradle
+ - name: Build Iceberg Open API project
+ run: ./gradlew :iceberg-open-api:shadowJar
+ - name: Login to Docker Hub
+ env:
+ DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
+ DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ docker login -u "$DOCKERHUB_USER" -p "$DOCKERHUB_TOKEN"
Review Comment:
i think this was changed recently, might need to rebase here
##########
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##########
@@ -36,43 +36,84 @@ env:
DOCKER_REPOSITORY: apache
jobs:
- build:
+ build-images:
if: github.repository_owner == 'apache'
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - runner: ubuntu-latest
+ platform: linux/amd64
+ arch: amd64
+ - runner: ubuntu-24.04-arm
+ platform: linux/arm64
+ arch: arm64
+ runs-on: ${{ matrix.runner }}
+ environment: docker-publish
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+ with:
+ persist-credentials: false
+
+ - uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5
+ with:
+ distribution: zulu
+ java-version: 21
+ - uses:
gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5 #
zizmor: ignore[cache-poisoning] -- cache writes are restricted to the default
branch by setup-gradle
+ - name: Build Iceberg Open API project
+ run: ./gradlew :iceberg-open-api:shadowJar
+ - name: Login to Docker Hub
+ env:
+ DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
+ DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ docker login -u "$DOCKERHUB_USER" -p "$DOCKERHUB_TOKEN"
+ - name: Set the tagged version
+ if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
+ env:
+ REF: ${{ github.ref }}
+ run: |
+ echo "DOCKER_IMAGE_VERSION=$(echo "$REF" | tr -d -c 0-9.)" >>
"$GITHUB_ENV"
+
+ - name: Set up Docker Buildx
+ uses:
docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd # v4.0.0
+
+ - name: Build and Push (per-arch)
+ uses:
docker/build-push-action@d08e5c354a6adb9ed34480a06d141179aa583294 # v7.0.0
+ with:
+ context: ./
+ file: ./docker/iceberg-rest-fixture/Dockerfile
+ platforms: ${{ matrix.platform }}
+ push: true
+ tags: |
+ ${{ env.DOCKER_REPOSITORY }}/${{ env.DOCKER_IMAGE_TAG }}:${{
env.DOCKER_IMAGE_VERSION }}-${{ matrix.arch }}
+
+ publish-manifest:
+ if: github.repository_owner == 'apache'
Review Comment:
```suggestion
```
nit: dont need this since build-images pre-req is already gated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
