ebyhr commented on code in PR #16007:
URL: https://github.com/apache/iceberg/pull/16007#discussion_r3098753344
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -98,6 +103,8 @@ private CatalogContext initializeBackendCatalog() throws
IOException {
LOG.info("No warehouse location set. Defaulting to temp location: {}",
warehouseLocation);
}
+ resolveCatalogNameFromEnv(catalogProperties, System.getenv());
Review Comment:
Why do we need this change? The `catalogProperties` comes from
[RCKUtils.environmentCatalogConfig()](https://github.com/apache/iceberg/blob/dde712ec9ed6c9d28183ee4615d50f97b246af5d/open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java#L64).
I expect it contains `CATALOG_NAME` environment variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
