tanmayrauth commented on code in PR #902:
URL: https://github.com/apache/iceberg-go/pull/902#discussion_r3090740778
##########
table/encryption.go:
##########
@@ -15,22 +15,12 @@
// specific language governing permissions and limitations
// under the License.
-package compaction
+package table
-import (
- "context"
- "fmt"
-
- "github.com/apache/iceberg-go/table"
-)
-
-// Analyze scans the table and produces a compaction Plan without
-// modifying anything. This is the dry-run / planning entry point.
-func Analyze(ctx context.Context, tbl *table.Table, cfg Config) (Plan, error) {
- tasks, err := tbl.Scan().PlanFiles(ctx)
- if err != nil {
- return Plan{}, fmt.Errorf("plan files for compaction analysis:
%w", err)
- }
-
- return cfg.PlanCompaction(tasks)
+// EncryptionKey represents an encryption key stored in table metadata (V3+).
+// Keys are indexed by KeyID in the metadata encryption-keys map.
+type EncryptionKey struct {
+ KeyID string `json:"key-id"`
+ KeyMetadata *string `json:"key-metadata,omitempty"`
+ KeyAlgorithm *string `json:"key-algorithm,omitempty"`
}
Review Comment:
Fixed. Renamed to encrypted-key-metadata, removed key-algorithm, added
properties field per the V3 spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
