laskoviymishka commented on code in PR #890:
URL: https://github.com/apache/iceberg-go/pull/890#discussion_r3089593181
##########
manifest.go:
##########
@@ -537,27 +485,21 @@ type ManifestFile interface {
setVersion(int)
}
-type fallbackManifest[T any] interface {
- ManifestFile
- toFile() *manifestFile
- *T
-}
-
-func decodeManifestsWithFallback[P fallbackManifest[T], T any](rd *ocf.Reader)
([]ManifestFile, error) {
- results := make([]ManifestFile, 0)
- for {
- tmp := P(new(T))
- if err := rd.Decode(tmp); err != nil {
- if errors.Is(err, io.EOF) {
- return results, nil
- }
-
- return nil, err
- }
+// fieldSummarySchemaNode is the FieldSummary Avro schema with "r508" as an
Review Comment:
[nit] first two lines describe fieldSummarySchemaNode — a variable from the
intermediate version that was removed when type-alias=r508 tag replaced it. The
sentence is incomplete ("...match the record name used by the") and then a new
sentence about manifestFileV1Reader starts. Maybe just delete this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
