xanderbailey commented on PR #2153: URL: https://github.com/apache/iceberg-rust/pull/2153#issuecomment-4255592306
Thanks for the review Matt: 1. IncrementalAppendScanBuilder agree here, this is nicer 2. seems reasonable to me 3. ignoring replace seems okay since I'd still be looking at the right "view" of the data. Ignoring deletes seems much weirdly to me (and something we've had to implement around in spark) because you're ignoring deletes so the "view" of the data isn't accurate but maybe the point is that changelog should deal with these semantics? and the incremental scan should just tell me "What data was appended?". Maybe we should also be consistent with the java implementation here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
