jonbjo opened a new pull request, #2335:
URL: https://github.com/apache/iceberg-rust/pull/2335
## Summary
This PR fixes the serialization of optional fields in `CreateTableRequest`
and related types to ensure they are omitted (rather than serialized as `null`)
when `None`.
This addresses issue where REST catalog implementations may reject requests
with explicit `null` values for optional fields.
## Changes
- Added `#[serde(skip_serializing_if = "Option::is_none")]` to optional
fields in:
- `CreateTableRequest`: `location`, `partition_spec`, `write_order`,
`stage_create`
- `UnboundPartitionField`: `field_id`
- `UnboundPartitionSpec`: `spec_id`
## Test Plan
Added comprehensive unit test `test_create_table_request_serde` that
verifies:
- Full serialization with all optional fields present
- Minimal serialization with only required fields (optional fields omitted,
not null)
## Related
- Addresses feedback from the original PR #2136
- Supersedes #2155
Closes #2089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
