steveloughran commented on PR #15428: URL: https://github.com/apache/iceberg/pull/15428#issuecomment-4253919542
@danielcweeks thanks for the review, updated the title. w.r.t that test body change, it came in when I was cherrypicking stuff from @adutra --I can't give a strong justification for it myself. I don't see any harm in having them in. Clients do need to provide that SHA256 checksum when uploading to a store which is configured to require these checksums (needed for object integrity scans later). So Alex's code is setting a good example for the rest of us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
