pvary commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3086481856
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -77,6 +77,14 @@ protected boolean supportsBatchReads() {
return false;
}
+ /**
+ * Hook for subclasses to declare whether they support all types in the
given schema. Default is
+ * to support all schemas. If false is returned, the test will be skipped
using assumeTrue.
+ */
+ protected boolean supports(Schema schema) {
+ return true;
+ }
+
Review Comment:
I agree.
We should have a very clear understanding what is supported and what is not
supported.
If an engine does not support a type, then it should be handled and
highlighted in the engine test.
We generally want to find all of the features which are not supported by all
of the FileFormats, and make sure they become suppoted. So as a first rule, we
should try to implement the feature in the formats, and as a second rule we can
create an exception exception in the main test in the `MISSING_FEATURES`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
