github-actions[bot] opened a new issue, #2329:
URL: https://github.com/apache/iceberg-rust/issues/2329

   
   > Rand is unsound with a custom logger using `rand::rng()`
   
   | Details             |                                                |
   | ------------------- | ---------------------------------------------- |
   | Status              | unsound                |
   | Package             | `rand`                      |
   | Version             | `0.10.0`                   |
   | URL                 | 
[https://github.com/rust-random/rand/pull/1763](https://github.com/rust-random/rand/pull/1763)
 |
   | Date                | 2026-04-09                         |
   
   It has been reported (by @lopopolo) that the `rand` library is 
[unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library)
 (i.e. that safe code using the public API can cause Undefined Behaviour) when 
all the following conditions are met:
   
   - The `log` and `thread_rng` features are enabled
   - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) 
is defined
   - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) 
and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
   - The `ThreadRng` (attempts to) reseed while called from the custom logger 
(this happens every 64 kB of generated data)
   - Trace-level logging is enabled or warn-level logging is enabled and the 
random source (the `getrandom` crate) is unable to provide a new seed
   
   `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to 
cast `*mut BlockRng<ReseedingCore>` to `&mut 
BlockRng<ReseedingCore>`. When all the above conditions are met this 
results in an aliased mutable reference, violating the Stacked Borrows rules. 
Miri is able to detect this violation in sample code. Since construction of 
[aliased mutable references is Undefined 
Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the 
behaviour of optimized builds is hard to predict.
   
   Affected versions of `rand` are `>= 0.7, < 0.9.3` and `0.10.0`.
   
   See [advisory page](https://rustsec.org/advisories/RUSTSEC-2026-0097.html) 
for additional details.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to