alliasgher opened a new pull request, #898: URL: https://github.com/apache/iceberg-go/pull/898
Fixes #324. `mergeConf` was checking `len(resConfig.Field) == 0` before applying values from the YAML config file. Since `docopt` populates `resConfig` with default values (e.g. `Output="text"`) before `mergeConf` runs, the file-config was silently ignored for any option that has a docopt default. **Fix:** scan `os.Args` to record which flags were explicitly provided, then apply the file-config value only when the corresponding flag was absent from the command line. CLI-provided values always take precedence; file-config fills in everything else. **Precedence after this change:** 1. Explicit CLI flag (highest) 2. YAML config file 3. docopt default (lowest) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
