zeroshade commented on code in PR #895:
URL: https://github.com/apache/iceberg-go/pull/895#discussion_r3082164238
##########
catalog/rest/options.go:
##########
@@ -58,6 +58,19 @@ func WithTLSConfig(config *tls.Config) Option {
}
}
+// WithOAuthTLSConfig sets a separate TLS configuration for the HTTP client
+// used to communicate with the OAuth2 server. This is useful when the OAuth2
+// server (oauth2-server-uri) is a different host than the catalog and requires
+// different TLS settings (e.g. a different CA or client certificate).
+//
+// If not set, the OAuth2 client reuses the catalog's HTTP client (and its TLS
+// configuration).
+func WithOAuthTLSConfig(config *tls.Config) Option {
Review Comment:
@laskoviymishka what do you think from an API point of view, would we
actually want to present a full `WithOAuthTransport` / `WithOAuthHTTPClient`?
Or do you think this is sufficient? I'm curious about your thoughts here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
