danielcweeks commented on code in PR #15955:
URL: https://github.com/apache/iceberg/pull/15955#discussion_r3075567457
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -70,7 +70,7 @@ class Coordinator extends Channel {
private static final Logger LOG = LoggerFactory.getLogger(Coordinator.class);
private static final ObjectMapper MAPPER = new ObjectMapper();
private static final String COMMIT_ID_SNAPSHOT_PROP =
"kafka.connect.commit-id";
- private static final String TASK_ID_SNAPSHOT_PROP = "kafka.connect.task-id";
+ private static final String COORDINATOR_ID_SNAPSHOT_PROP =
"kafka.connect.coordinator-id";
Review Comment:
This rename feels like an unnecessary clarification. They both really mean
the same thing and updating an existing property causes more problems than it's
worth. It's assumed that that the task identified is the coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
