danielcweeks commented on code in PR #15792:
URL: https://github.com/apache/iceberg/pull/15792#discussion_r3075445721
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3InputStream.java:
##########
@@ -62,4 +66,36 @@ void testReadTailClosesTheStream() throws IOException {
verify(inputStream).close();
}
+
+ @Test
+ void testReadRetriesOnPrematureConnectionClose() throws IOException {
Review Comment:
This doesn't feel like a great way to test this. We're just throwing what
we expect to see. Can we update this to use the apache client so that it
actually throws? This would also insulate us from a client change to the
messaging if the upstream library were to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
