danielcweeks commented on code in PR #15283:
URL: https://github.com/apache/iceberg/pull/15283#discussion_r3074090274
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -464,6 +479,222 @@ protected Temporal convertTimestampValue(Object value,
TimestampType type) {
return convertLocalDateTime(value);
}
+ protected Variant convertVariantValue(Object value) {
+ if (value instanceof ByteBuffer) {
+ return Variant.from((ByteBuffer) value);
Review Comment:
@seokyun-ha-toss I still don't think this has been addressed.
I think it's fine to check and pass through a variant if it is an instance
of a variant. I think it's unexpected as I noted in another comment (I suppose
this could be done through an SMT, but I'm not sure if that's a real scenario).
However, if we see a bytebuffer, I don't see why we would assume it's a
variant as opposed to a literal binary. That is what the comment originally was
intended to address, but it appears we're still treating it as a variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
