ebyhr commented on code in PR #15958:
URL: https://github.com/apache/iceberg/pull/15958#discussion_r3070291712
##########
api/src/test/java/org/apache/iceberg/catalog/TestTableIdentifier.java:
##########
@@ -52,6 +53,18 @@ public void testToLowerCase() {
.isEqualTo(TableIdentifier.of("Catalog", "dB", "TBL").toLowerCase());
}
+ @Test
+ public void testToLowerCaseIsLocaleIndependent() {
+ Locale defaultLocale = Locale.getDefault();
Review Comment:
The default location is stored in global state, so changing it could affect
other tests if they run concurrently. To avoid this, we could use JUnit
Pioneer, which is already used by TestAliyunClientFactories.
```java
@Test
@DefaultLocale(language = "tr")
public void testToLowerCaseIsLocaleIndependent() {
assertThat(TableIdentifier.of("information", "db", "tbl"))
.isEqualTo(TableIdentifier.of("INFORMATION", "DB",
"TBL").toLowerCase());
}
```
The library isolates any test that has the `@DefaultLocale` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
