manuzhang commented on code in PR #15043:
URL: https://github.com/apache/iceberg/pull/15043#discussion_r3042831267
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -195,7 +196,9 @@ private static Server initHttpServer() throws Exception {
ServletContextHandler servletContext =
new ServletContextHandler(ServletContextHandler.NO_SESSIONS);
servletContext.addServlet(new ServletHolder(servlet), "/*");
- servletContext.setHandler(new GzipHandler());
+ CompressionHandler compressionHandler = new CompressionHandler();
Review Comment:
As per
https://jetty.org/docs/jetty/12.1/programming-guide/server/http.html#handler-use-compression,
> CompressionHandler discovers compression algorithm implementations via
Java’s ServiceLoader mechanism, so it is enough to put the Jetty artifacts with
the compression implementation in the module-path or class-path
Do we need to explicitly create and put `GzipCompression`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
