singhpk234 commented on PR #15500:
URL: https://github.com/apache/iceberg/pull/15500#issuecomment-4188378832
Thanks for analysis @RussellSpitzer, I was mostly curious about how jvm
flags can influence host verification now, when JSSE is being used one such
flag `jdk.tls.trustNameService`
switching the default verification engine from Apache's library to JSSE
exposes a knob that was previously irrelevant. specially what if JVM was
running with this flag on will now come into effect in rest client
But
- It defaults to false
- It's static final, set at JVM boot (not exploitable in runtime)
- Anyone setting it to true has already made a conscious decision to trust
their DNS
- The attack requires controlling both the JVM launch flags AND a DNS
server - at that point one have bigger problems
It was not meant to be a blocker of this pr, but more from curiously purpose
and i think we should proceed if there is a concencus on the approach.
Though one thing I think while researching this flag, i would **recommend**
we mention this in the release notes explictly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
