rlamarche commented on PR #2300: URL: https://github.com/apache/iceberg-rust/pull/2300#issuecomment-4177719902
> Hi, @rlamarche thanks for this pr! We should use similar interface as java: https://github.com/apache/iceberg/blob/817dc35a924b403716d2eb899aba46f3398a5ca9/core/src/main/java/org/apache/iceberg/io/SupportsStorageCredentials.java#L27 Thank you for your feedback ! What would be the "rusty" way to do this ? https://github.com/apache/iceberg/blob/3e22f850bd21f3f8f4ecb340a5d4ffe468fb1ced/core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java#L179 ```java if (io instanceof SupportsStorageCredentials && !((SupportsStorageCredentials) io).credentials().equals(storageCredentials)) { ((SupportsStorageCredentials) io).setCredentials(storageCredentials); } ``` `StorageFactory` is a `Arc<dyn StorageFactory>`. Maybe the storage credentials should be added to the `StorageConfig`, so the `StorageFactory` implementation could handle it (in `OpenDalResolvingStorage` struct). This would be closer to the `ResolvingFileIO` class in java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
