emkornfield commented on code in PR #2288:
URL: https://github.com/apache/iceberg-rust/pull/2288#discussion_r3003510433
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -85,13 +85,15 @@ pub(crate) fn parse_metadata_file_compression(
// Validate that only None and Gzip are used for metadata
match codec {
- CompressionCodec::None | CompressionCodec::Gzip => Ok(codec),
- CompressionCodec::Lz4 | CompressionCodec::Zstd => Err(Error::new(
- ErrorKind::DataInvalid,
- format!(
- "Invalid metadata compression codec: {value}. Only 'none' and
'gzip' are supported for metadata files."
- ),
- )),
+ CompressionCodec::None | CompressionCodec::Gzip(_) => Ok(codec),
+ CompressionCodec::Lz4 | CompressionCodec::Zstd(_) |
CompressionCodec::Snappy => {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
