zeroshade commented on code in PR #815:
URL: https://github.com/apache/iceberg-go/pull/815#discussion_r3003285280
##########
catalog/rest/options.go:
##########
@@ -115,6 +115,18 @@ func WithScope(scope string) Option {
}
}
+func WithAudience(audience string) Option {
+ return func(o *options) {
+ o.audience = audience
+ }
+}
+
+func WithResource(resource string) Option {
+ return func(o *options) {
+ o.resource = resource
+ }
+}
Review Comment:
Just add some docstring comments for these please. Otherwise this looks good
to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
