mxm commented on code in PR #15772: URL: https://github.com/apache/iceberg/pull/15772#discussion_r2999834941
########## docs/docs/flink.md: ########## @@ -175,20 +175,20 @@ Run a query: For more details, please refer to the [Python Table API](https://ci.apache.org/projects/flink/flink-docs-release-{{ flinkVersionMajor }}/docs/dev/python/table/intro_to_table_api/). -## Adding catalogs. +## Adding catalogs -Flink support to create catalogs by using Flink SQL. +Flink supports creating catalogs using Flink SQL. ### Catalog Configuration A catalog is created and named by executing the following query (replace `<catalog_name>` with your catalog name and -`<config_key>`=`<config_value>` with catalog implementation config): +`'<config_key>'='<config_value>'` with catalog implementation config): ```sql CREATE CATALOG <catalog_name> WITH ( 'type'='iceberg', - `<config_key>`=`<config_value>` -); + '<config_key>'='<config_value>' Review Comment: ```suggestion '<config_key>' = '<config_value>' ``` NIT readability ########## docs/docs/flink.md: ########## @@ -175,20 +175,20 @@ Run a query: For more details, please refer to the [Python Table API](https://ci.apache.org/projects/flink/flink-docs-release-{{ flinkVersionMajor }}/docs/dev/python/table/intro_to_table_api/). -## Adding catalogs. +## Adding catalogs -Flink support to create catalogs by using Flink SQL. +Flink supports creating catalogs using Flink SQL. ### Catalog Configuration A catalog is created and named by executing the following query (replace `<catalog_name>` with your catalog name and -`<config_key>`=`<config_value>` with catalog implementation config): +`'<config_key>'='<config_value>'` with catalog implementation config): Review Comment: ```suggestion `'<config_key>' = '<config_value>'` with catalog implementation config): ``` NIT readability -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
