laskoviymishka commented on issue #797: URL: https://github.com/apache/iceberg-go/issues/797#issuecomment-4130464018
Thanks, this is valid issue. Worth noting this is trickier than it appears: iceberg-go has essentially no logging infrastructure today. Using log.Printf in library code is problematic since it pollutes stderr with no way for consumers to silence or redirect it. We may go with log/slog for these two warnings (timestamp downcast + unrecognized codec). Consumers can control output via slog.SetDefault(), including silencing entirely. It's a reasonable stopgap without any API changes. Longer term, threading a *slog.Logger through the core types via functional options would be the proper solution — the pattern already exists in the codebase, it's just plumbing work. I made a PR: #811 @zeroshade — would appreciate your take on the logging approach here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
