emkornfield commented on code in PR #605:
URL: https://github.com/apache/iceberg-cpp/pull/605#discussion_r2990121743
##########
src/iceberg/deletes/roaring_position_bitmap.cc:
##########
@@ -117,24 +117,26 @@ RoaringPositionBitmap& RoaringPositionBitmap::operator=(
RoaringPositionBitmap::RoaringPositionBitmap(std::unique_ptr<Impl> impl)
: impl_(std::move(impl)) {}
-Status RoaringPositionBitmap::Add(int64_t pos) {
- ICEBERG_RETURN_UNEXPECTED(ValidatePosition(pos));
+void RoaringPositionBitmap::Add(int64_t pos) {
+ if (pos < 0 || pos > kMaxPosition) {
Review Comment:
I'm OK with this, i think this case is a little bit less clear then the read
side though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
