tomighita commented on PR #2120: URL: https://github.com/apache/iceberg-rust/pull/2120#issuecomment-4124539044
@LLDay I think it would be a lot cleaner to build on top of this PR and build a newly dedicated `rename_column` method, similar to other implementations (like you mentioned). The reason I did not add it in this PR is because I wanted to keep things relatively small/contained to make it easier to review. That's a good call: before refactoring this PR, you could add a FieldRef directly, which after implementing @blackmwk's suggestion I don't think is possible any longer. In this case, we can even remove the `disable_id_auto_assignment` method. However, I would personally be in favor of keeping this and allowing again the user to specify these type of operations where they want more control of assigning ids. Anyone any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
