rambleraptor commented on code in PR #23:
URL: https://github.com/apache/iceberg-terraform/pull/23#discussion_r2962816394
##########
internal/provider/resource_table.go:
##########
@@ -96,6 +98,64 @@ func (r *icebergTableResource) Schema(_ context.Context, _
resource.SchemaReques
},
},
},
+ "partition_spec": rscschema.SingleNestedAttribute{
+ Description: "The partition spec of the table.",
+ Optional: true,
+ Computed: true,
+ Attributes: map[string]rscschema.Attribute{
+ "fields": rscschema.ListNestedAttribute{
+ Description: "The fields of the
partition spec.",
+ Required: true,
+ NestedObject:
rscschema.NestedAttributeObject{
+ Attributes:
map[string]rscschema.Attribute{
+ "source_id":
rscschema.Int64Attribute{
+
Description: "The source field ID.",
+
Required: true,
+ },
Review Comment:
Cool. We'll have to do some more work in the JSON <-> Iceberg-Go <-> TF
conversion layers, since Iceberg-Go just has [source_id as a
int](https://github.com/apache/iceberg-go/blob/d0cc60deeb8b98e9aa6663e3ed0e2e1ff622acaa/partitions.go#L45)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
