wgtmac commented on code in PR #587:
URL: https://github.com/apache/iceberg-cpp/pull/587#discussion_r2929671982
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -39,9 +39,9 @@ namespace iceberg::rest {
/// \brief Server-provided configuration for the catalog.
struct ICEBERG_REST_EXPORT CatalogConfig {
- std::unordered_map<std::string, std::string> defaults; // required
- std::unordered_map<std::string, std::string> overrides; // required
- std::vector<Endpoint> endpoints;
+ std::unordered_map<std::string, std::string> defaults{}; // required
Review Comment:
Do we really need to explicitly initialize STL containers?
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -142,13 +142,13 @@ struct ICEBERG_REST_EXPORT RenameTableRequest {
/// \brief Request to create a table.
struct ICEBERG_REST_EXPORT CreateTableRequest {
- std::string name; // required
- std::string location;
- std::shared_ptr<Schema> schema; // required
- std::shared_ptr<PartitionSpec> partition_spec;
- std::shared_ptr<SortOrder> write_order;
+ std::string name = ""; // required
+ std::string location = "";
+ std::shared_ptr<Schema> schema = nullptr; // required
Review Comment:
Same question here, do we actually need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
