Fokko commented on code in PR #3009:
URL: https://github.com/apache/iceberg-python/pull/3009#discussion_r2923406366
##########
pyiceberg/manifest.py:
##########
@@ -1184,6 +1184,92 @@ def existing(self, entry: ManifestEntry) ->
ManifestWriter:
return self
+class RollingManifestWriter:
+ """As opposed to ManifestWriter, a rolling writer could produce multiple
manifest files."""
+
+ _ROWS_DIVISOR = 250
Review Comment:
In Java we target at the size, controlled by
`commit.manifest.target-size-bytes`. Any chance we can do something similar
here? Or at least have some rationale behind this number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
