nssalian opened a new pull request, #3142:
URL: https://github.com/apache/iceberg-python/pull/3142
Closes #3127
# Rationale for this change
`pa.timestamp("ns", tz="US/Pacific") converts to TimestampNanoType()`
(tz-naive) instead of raising `TypeError`. The `us` path correctly rejects
non-UTC timezones.
raises TypeError
`visit_pyarrow(pa.timestamp("us", tz="US/Pacific"), _ConvertToIceberg())`
silently drops timezone
`visit_pyarrow(pa.timestamp("ns", tz="US/Pacific"),
_ConvertToIceberg(format_version=3))`
Fixes this by adding the correct elif clause
## Are these changes tested?
Yes - added a couple of tests in the pyarrow visitor
## Are there any user-facing changes?
It fixes the behavior that was a bug, so I think it would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
