mxm commented on PR #15312: URL: https://github.com/apache/iceberg/pull/15312#issuecomment-4031677872
> by the way, what is the policy wrt setting the above review items as "Resolved" - should I have done that when making changes or the reviewers - to denote they are happy with how it was changed? as I think all of them are resolved by now but there is quite a few left unmarked as such :) AFAIK there is no official policy, but I think it is good practice for the PR author to resolve them as they get addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
